feat: add support for UpgradePolicy attribute in cluster creation #8534
Conversation
guessi
force-pushed
the
feature/upgrade-policy-support
branch
2 times, most recently
from
b00f0d6 to
6927aa3
Compare
guessi
force-pushed
the
feature/upgrade-policy-support
branch
2 times, most recently
from
ae878d6 to
e04f40b
Compare
|
@NicholasBlaskey Just made an update to address issues that you pointed out - e04f40b thanks ! |
guessi
force-pushed
the
feature/upgrade-policy-support
branch
from
6cf02eb to
a6c8769
Compare
| # UpgradePolicy allows you to specify the support type for your cluster | ||
| # Valid values are "STANDARD" and "EXTENDED (default)" | ||
| # - https://docs.aws.amazon.com/eks/latest/APIReference/API_UpgradePolicyRequest.html | ||
| upgradePolicy: |
There was a problem hiding this comment.
Could we move upgradePolicy outside of metadata and put it as a top level field?
There was a problem hiding this comment.
@NicholasBlaskey thanks for your review, I simplified the sample config - 3ba2905 please review again, thanks!
There was a problem hiding this comment.
Could we move upgradePolicy out of metadata and make it on the same level like managedNodegroups
For example so the user would have to specify
metadata:
name: upgrade-policy-cluster
region: us-west-2
upgradePolicy:
supportType: "EXTENDED"
managedNodeGroups:
- name: mng-1
desiredCapacity: 1
We will need to update both the example and the code to account for this change. This change would help match the structure of the create cluster EKS API.
There was a problem hiding this comment.
Oh... Yes, I misunderstood what you mean.
Will do, thanks!
guessi
force-pushed
the
feature/upgrade-policy-support
branch
from
3a5295a to
bddce1a
Compare
guessi
force-pushed
the
feature/upgrade-policy-support
branch
from
bddce1a to
dd6a97f
Compare
2 participants
Adds support for UpgradePolicy attribute during cluster creation, allowing users to specify support type (STANDARD or EXTENDED) for EKS clusters.
Resolves #7932